Skip to content

Flink: fix flaky test that might fail due to classloader check#9216

Merged
pvary merged 1 commit intoapache:mainfrom
stevenzwu:fix-flink-test-classloader
Dec 5, 2023
Merged

Flink: fix flaky test that might fail due to classloader check#9216
pvary merged 1 commit intoapache:mainfrom
stevenzwu:fix-flink-test-classloader

Conversation

@stevenzwu
Copy link
Contributor

@stevenzwu stevenzwu commented Dec 5, 2023

No description provided.

@stevenzwu stevenzwu requested a review from pvary December 5, 2023 00:32
@github-actions github-actions bot added the flink label Dec 5, 2023
@stevenzwu
Copy link
Contributor Author

stevenzwu commented Dec 5, 2023

see an example of failed test here: https://github.com/apache/iceberg/actions/runs/7091452262/job/19300609355?pr=9212

    exception caught while trying to get the future result: java.util.concurrent.ExecutionException: java.lang.IllegalStateException: Trying to access closed classloader. Please check if you store classloaders directly or indirectly in static fields. If the stacktrace suggests that the leak occurs in a third party library and cannot be fixed immediately, you can disable this check with the configuration 'classloader.check-leaked-classloader'.
    	at java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357)
    	at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1928)
    	at org.assertj.core.internal.Futures.assertSucceededWithin(Futures.java:109)
    	at org.assertj.core.api.AbstractCompletableFutureAssert.internalSucceedsWithin(AbstractCompletableFutureAssert.java:400)
    	at org.assertj.core.api.AbstractCompletableFutureAssert.succeedsWithin(AbstractCompletableFutureAssert.java:396)
    	at org.apache.iceberg.flink.source.TestIcebergSourceWithWatermarkExtractor.waitForRecords(TestIcebergSourceWithWatermarkExtractor.java:416)
    	at org.apache.iceberg.flink.source.TestIcebergSourceWithWatermarkExtractor.testThrottling(TestIcebergSourceWithWatermarkExtractor.java:307)

@pvary pvary merged commit cbd33a6 into apache:main Dec 5, 2023
@pvary
Copy link
Contributor

pvary commented Dec 5, 2023

Thanks for catching and fixing this @stevenzwu !

stevenzwu added a commit to stevenzwu/iceberg that referenced this pull request Dec 5, 2023
@stevenzwu
Flink: backport PR apache#9216 for disabling classloader check
52441a0
nastra pushed a commit that referenced this pull request Dec 5, 2023
@stevenzwu
Flink: backport PR #9216 for disabling classloader check (#9226)
7b12a41
@pvary pvary mentioned this pull request Dec 6, 2023
Merged
@stevenzwu stevenzwu mentioned this pull request Dec 6, 2023
Merged
This was referenced Dec 11, 2023
Closed
Closed
@amogh-jahagirdar amogh-jahagirdar mentioned this pull request Dec 11, 2023
Closed
@ajantha-bhat
Copy link
Member

ajantha-bhat commented Dec 14, 2023

I think this is not fully fixed.

With the latest code, it has failed again
https://github.com/apache/iceberg/actions/runs/7208855885/job/19638664888?pr=9296

cc: @nastra, @stevenzwu, @pvary

@ajantha-bhat
Copy link
Member

ajantha-bhat commented Dec 14, 2023

@stevenzwu: Looks like the code is already there in 1.16, but still it is failed. Please take a look.

@stevenzwu
Copy link
Contributor Author

stevenzwu commented Dec 15, 2023 •
edited
Loading

@pvary can you follow up? if this can't be fixed quickly, let's ignore this test for now

@pvary
Copy link
Contributor

pvary commented Dec 15, 2023

I was originally not able to run the tests multiple times using IntelliJ, but found some issues, and fixed them.
Now I have a test which I was able to run 1000 times from IntelliJ without errors.
Let me prepare the PR

@pvary pvary mentioned this pull request Dec 15, 2023
Merged
lisirrx pushed a commit to lisirrx/iceberg that referenced this pull request Jan 4, 2024
@stevenzwu @lisirrx
Flink: fix flaky test that might fail due to classloader check (apach…
965806f 
…e#9216)
lisirrx pushed a commit to lisirrx/iceberg that referenced this pull request Jan 4, 2024
@stevenzwu @lisirrx
Flink: backport PR apache#9216 for disabling classloader check (apach…
1503f9a 
…e#9226)
rodmeneses pushed a commit to rodmeneses/iceberg that referenced this pull request Feb 19, 2024
@stevenzwu @rodmeneses
Flink: fix flaky test that might fail due to classloader check (apach…
b2f0f8f 
…e#9216)
rodmeneses added a commit to rodmeneses/iceberg that referenced this pull request Feb 19, 2024
@rodmeneses
Flink: backport PR apache#9216 for disabling classloader check (apach…
8a45500 
…e#9226)
devangjhabakh pushed a commit to cdouglas/iceberg that referenced this pull request Apr 22, 2024
@stevenzwu @devangjhabakh
Flink: fix flaky test that might fail due to classloader check (apach…
1e9db1a 
…e#9216)
devangjhabakh pushed a commit to cdouglas/iceberg that referenced this pull request Apr 22, 2024
@stevenzwu @devangjhabakh
Flink: backport PR apache#9216 for disabling classloader check (apach…
ffaf822 
…e#9226)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nastra nastra nastra approved these changes

@pvary pvary pvary approved these changes

Assignees

No one assigned

Labels

flink

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stevenzwu @pvary @ajantha-bhat @nastra